Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled CodeyBot to nuke message without PDFs in #resume-critique and DM user with explanation #505

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

KuroganeToyama
Copy link
Contributor

Summary of Changes

  • Imported channelMention and userMention from discord.js for the embed
  • Nuke messages without PDFs in #resume-critique
  • DM user with embed explaining why their message got nuked

Related Issues

Steps to Reproduce

  • Send a message without attachment, with non-PDF attachments, and with PDFs to see the bot in action

Notes

  • I chose to use embeds for the DM because the formatting looks nicer. Still open to any suggestions to make the writing more appealing
  • Not sure if we need to use Logger for await message.delete() and await client.users.send(user, { embeds: [explainEmbed] })

Copy link
Contributor

@probro27 probro27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KuroganeToyama Great job with the ticket. Just work on adding the image condition. If there is any issues with supporting certain image formats then we can discuss that.

src/events/messageCreate.ts Outdated Show resolved Hide resolved
@probro27
Copy link
Contributor

@KuroganeToyama Great job! Can you fix the linting errors. Rest looks solid, I'll check it out

Copy link
Contributor

@probro27 probro27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KuroganeToyama LGTM! I'll just wait for @Fan-Yang-284 to check this PR out as well and approve it. Once he has approved we can squash and merge it. Thank you so much for figuring out a way to meet our demands.

Copy link
Contributor

@Fan-Yang-284 Fan-Yang-284 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KuroganeToyama KuroganeToyama merged commit 056ee25 into main Jan 23, 2024
2 checks passed
@KuroganeToyama KuroganeToyama deleted the issue-#432 branch January 23, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuke messages with no attachments in #resume-critique
3 participants