Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch infinite money glitch by mutexing coin transfers and blackjack #526

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

hyperneutrino
Copy link
Contributor

Summary of Changes

  • currently, users can start a blackjack game, transfer their money away, and since balance cannot be negative, they are protected from losses and can get infinite money for free
  • this fixes this by preventing transfers and blackjack games from ongoing concurrently

Related Issues

Steps to Reproduce

  • attempt to start a blackjack game while a transfer is pending, or attempt to start a transfer while playing blackjack

Copy link
Contributor

@probro27 probro27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyper-neutrino LTGM! Thanks for catching this bug. This is a good fix. We are good to go :D

@hyperneutrino hyperneutrino merged commit 237d536 into main Jun 19, 2024
2 checks passed
@hyperneutrino hyperneutrino deleted the hyper/523/fix-infinite-money-glitch branch June 19, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants