Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable Plot attribution #313

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

mbostock
Copy link
Contributor

@mbostock mbostock commented Mar 4, 2024

Hi @jheer! We noticed that you’re including portions of Observable Plot’s source code in Mosaic. You’re welcome to do so, but you must include a copy of our LICENSE. (This PR combines it into your top-level LICENSE, but you could put the license within the relevant source files if you prefer, as you do for jstat.) We also recommend including links back to the original source so that it’s easier to check if things have changed.

Note that you can import the spatial interpolators from Plot directly if you don’t want to copy the source (but it appears you’ve changed the signatures slightly so perhaps that won’t work for you):

https://github.com/observablehq/plot/blob/41a63e372453d2f95e7a046839dfd245d21e7660/src/index.js#L25

And we improved the isColor routine to support CSS Color Module Level 5 in observablehq/plot#1454:

https://github.com/observablehq/plot/blob/41a63e372453d2f95e7a046839dfd245d21e7660/src/options.js#L464-L477

@jheer jheer merged commit 225ae30 into uwdata:main Mar 4, 2024
2 checks passed
@jheer
Copy link
Member

jheer commented Mar 4, 2024

Thank you @mbostock!!

@mbostock mbostock deleted the mbostock/plot-attribution branch March 4, 2024 16:54
@jheer
Copy link
Member

jheer commented Mar 4, 2024

In general I'd prefer reusing Plot's interpolators, but wanted to pass in a pre-allocated raster array (hence the signature change). Also FWIW, I noted that in the original implementation the barycentric interpolator can still leave some pixels as NaN (after an initial NaN fill). This became apparent as floating point issues in downstream code. I'm planning to file an issue for Plot, but probably won't have time to put together a standalone repro for at least a week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants