Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jheer! We noticed that you’re including portions of Observable Plot’s source code in Mosaic. You’re welcome to do so, but you must include a copy of our LICENSE. (This PR combines it into your top-level LICENSE, but you could put the license within the relevant source files if you prefer, as you do for jstat.) We also recommend including links back to the original source so that it’s easier to check if things have changed.
Note that you can import the spatial interpolators from Plot directly if you don’t want to copy the source (but it appears you’ve changed the signatures slightly so perhaps that won’t work for you):
https://github.com/observablehq/plot/blob/41a63e372453d2f95e7a046839dfd245d21e7660/src/index.js#L25
And we improved the
isColor
routine to support CSS Color Module Level 5 in observablehq/plot#1454:https://github.com/observablehq/plot/blob/41a63e372453d2f95e7a046839dfd245d21e7660/src/options.js#L464-L477