Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor inputs, add better types. #686

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Refactor inputs, add better types. #686

merged 2 commits into from
Feb 14, 2025

Conversation

jheer
Copy link
Member

@jheer jheer commented Feb 14, 2025

  • Add Input class, update inputs to inherit from it.
  • Add types for input generation methods.
  • Add types and docs for table options.

@jheer jheer requested a review from rpechuk February 14, 2025 00:10
domoritz
domoritz approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think #687 is the cleaner way for vitest to get it working with workspaces and in individual packages.

rpechuk
rpechuk approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@rpechuk rpechuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should we do something similar with Interactors?

@domoritz
Copy link
Member

I removed the vitest changes from this pull request.

@jheer jheer merged commit 12f0c1d into main Feb 14, 2025
3 checks passed
@jheer jheer deleted the jh/inputs branch February 14, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz approved these changes

@rpechuk rpechuk rpechuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jheer @domoritz @rpechuk