fix: remove cache from fetch options #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jheer
approved these changes
Oct 17, 2025
|
I've been meaning to look into why that was happening. This is great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
cache: 'no-cache'from RestConnector.Having
cache: 'no-cache'causes repeated OPTIONS requests to check CORS status unnecessarily. This increases overall response time.Also, I believe HTTP caching rarely applies to POST anyway.
With
cache: 'no-cache':Without setting
cacheoption:Alternatively, we could add a param for
fetchcall in the constructor of RestConnector similar toipc