Fix selection reset fully reseting downstream selection

packages/mosaic/core/src/Selection.ts

@@ -214,9 +214,9 @@ export class Selection extends Param<SelectionClauseArray> {
   reset(clauses?: SelectionClause[]): this {
     clauses ??= this._resolved;
     clauses.forEach(c => c.source?.reset?.());
-    this._resolved = this._resolved.filter(c => clauses!.includes(c));
+    this._resolved = this._resolved.filter(c => !clauses!.includes(c));
     this._relay.forEach(sel => sel.reset(clauses));
-    return super.update(this._resolved = []);
+    return super.update(this._resolved);
   }
 
   /**
@@ -388,4 +388,4 @@ export class SelectionResolver {
     }
     return null;
   }
-}
+}

packages/mosaic/core/test/selection.test.ts

@@ -0,0 +1,63 @@
+import { describe, it, expect } from "vitest";
+import { clausePoint, Selection } from "../src/index.js";
+
+describe("Selection", () => {
+  it("can be reset", () => {
+    const selection = new Selection();
+    const clause = clausePoint("column", 5, { source: {} });
+    selection.update(clause);
+
+    expect(selection.clauses[0]).toEqual(clause);
+    expect(selection.clauses).toHaveLength(1);
+    selection.reset();
+    expect(selection.clauses).toEqual([]);
+  });
+
+  it("relays reset downstream ", () => {
+    const selectionA = new Selection();
+    const selectionB = new Selection();
+    const upstreamSelection = Selection.crossfilter({
+      include: [selectionA, selectionB],
+    });
+
+    const clauseA = clausePoint("a", 1, { source: {} });
+    const clauseB = clausePoint("b", 2, { source: {} });
+
+    selectionA.update(clauseA);
+    selectionB.update(clauseB);
+
+    expect(upstreamSelection.clauses).toHaveLength(2);
+    expect(upstreamSelection.clauses).toContain(clauseA);
+    expect(upstreamSelection.clauses).toContain(clauseB);
+
+    selectionB.reset();
+    expect(upstreamSelection.clauses).toHaveLength(1);
+    expect(upstreamSelection.clauses).toContain(clauseA);
+
+    selectionA.reset();
+    expect(upstreamSelection.clauses).toHaveLength(0);
+  });
+
+  it("can specify a clause to reset", () => {
+    const selectionA = new Selection();
+    const selectionB = new Selection();
+    const upstreamSelection = Selection.crossfilter({
+      include: [selectionA, selectionB],
+    });
+
+    const clauseA = clausePoint("a", 1, { source: {} });
+    const clauseB = clausePoint("b", 2, { source: {} });
+
+    selectionA.update(clauseA);
+    selectionB.update(clauseB);
+
+    expect(upstreamSelection.clauses).toHaveLength(2);
+    expect(upstreamSelection.clauses).toContain(clauseA);
+    expect(upstreamSelection.clauses).toContain(clauseB);
+
+    upstreamSelection.reset([clauseB]);
+    expect(upstreamSelection.clauses).toHaveLength(1);
+    expect(upstreamSelection.clauses).toContain(clauseA);
+
+  });
+});