Skip to content

Escape quotes in SQL identifier strings. #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2025
Merged

Escape quotes in SQL identifier strings. #914

merged 2 commits into from
Oct 23, 2025

Conversation

@jheer
Copy link
Member

@jheer jheer commented Oct 22, 2025

  • Fix: escape quotes in SQL identifier strings during mosaic-sql string serialization.
  • Add test cases for mosaic-sql column references.

cc: @flekschas

@jheer jheer requested a review from domoritz as a code owner October 22, 2025 18:21
domoritz
domoritz approved these changes Oct 23, 2025
View reviewed changes
@jheer jheer merged commit d4c857f into main Oct 23, 2025
4 checks passed
@jheer jheer deleted the jh/sql-escape-id-quotes branch October 23, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domoritz domoritz domoritz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jheer @domoritz