feature(rf optimizations): enabling oneDPL and sort primitive refactoring #3046

Alexandr-Solovev · 2025-01-16T15:58:06Z

Description:

RF optimizations: enabling oneDPL and sort primitive refactoring and several functions optimization

Summary:

This PR introduces oneDPL enabling and radix sort replacement. Also the engine_type support has been added for RF GPU. A lot of CPU functions have been replaced with GPU analogues.

PR completeness and readability

I have reviewed my changes thoroughly before submitting this pull request.
I have commented my code, particularly in hard-to-understand areas.
I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
I have added a respective label(s) to PR if I have a permission for that.
I have resolved any merge conflicts that might occur with the base branch.

Testing

I have run it locally and tested the changes extensively.
All CI jobs are green or I have provided justification why they aren't.
I have extended testing suite if new functionality was introduced in this PR.

Performance

I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
I have provided justification why performance has changed or why changes are not expected.
I have provided justification why quality metrics have changed or why changes are not expected.
I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

WORKSPACE

david-cortes-intel · 2025-01-20T07:52:04Z

Before merging, please remember to add this new dependency to the installation instructions in INSTALL.md, along with instructions for setting necessary env. variables when using conda:
https://github.com/uxlfoundation/oneDAL/blob/main/INSTALL.md

Alexandr-Solovev · 2025-01-22T20:28:28Z

/intelci: run

.ci/pipeline/ci.yml

Alexandr-Solovev · 2025-03-20T16:15:35Z

/intelci: run

ethanglaser · 2025-03-20T16:34:40Z

Job with uxlfoundation/scikit-learn-intelex#2370: http://intel-ci.intel.com/f005a91e-e3e9-f19b-b9c7-a4bf010d0e2d

ethanglaser · 2025-03-20T21:22:03Z

Please resolve docbuild fail before merge: https://dev.azure.com/daal/DAAL/_build/results?buildId=44462&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=5caf77c8-9b10-50ef-b5c7-ca89c63e1c86&l=950

ethanglaser

LGTM, CI is green, and I have ran this enough times on cluster to know it works :) but would wait for others on feedback for specific implementation details

cpp/oneapi/dal/algo/decision_forest/backend/gpu/train_feature_type_dpc.cpp

cpp/oneapi/dal/backend/primitives/rng/device_engine_dpc.cpp

Alexandr-Solovev · 2025-03-21T09:56:18Z

/azp run CI

azure-pipelines · 2025-03-21T09:56:30Z

Azure Pipelines successfully started running 1 pipeline(s).

Alexandr-Solovev · 2025-03-21T10:20:30Z

/intelci: run

Alexandr-Solovev · 2025-03-21T11:43:01Z

/intelci: run

ethanglaser · 2025-03-21T14:13:19Z

/azp run CI

azure-pipelines · 2025-03-21T14:13:30Z

Azure Pipelines successfully started running 1 pipeline(s).

icfaust · 2025-03-21T16:23:37Z

.ci/env/apt.sh

 function install_mkl {
    sudo apt-get install -y intel-oneapi-mkl-devel-2025.0
    install_tbb
+    install_dpl


Is dpl a dependency of MKL? I thought tbb was integrated here to install_mkl for that reason

I guess mkl and tbb have no deps on each other, but my understanding its a step for install all necessary deps for onedal

icfaust · 2025-03-21T16:29:31Z

.ci/env/apt.sh

@@ -129,6 +134,9 @@ elif [ "${component}" == "tbb" ]; then
 elif [ "${component}" == "mkl" ]; then
    add_repo
    install_mkl
+elif [ "${component}" == "dpl" ]; then
+    add_repo
+    install_dpl


add to the help list at the end of this file "dpl"

icfaust · 2025-03-21T16:31:15Z

MODULE.bazel

+    name = "dpl",
+    root_env_var = "DPL_ROOT",
+    urls = [
+        "https://files.pythonhosted.org/packages/95/f6/18f78cb933e01ecd9e99d37a10da4971a795fcfdd1d24640799b4050fdbb/onedpl_devel-2022.7.1-py2.py3-none-manylinux_2_28_x86_64.whl",


Dumb question, but how do we find these values/maintain them? It looks painful.

we do the same thing for all other packages like tbb and mkl. Find it on pypi and copy links)

icfaust · 2025-03-21T16:32:59Z

cpp/oneapi/dal/algo/decision_forest/backend/gpu/train_feature_type_dpc.cpp

    auto src_ind = pr::ndarray<Index, 1>::empty(queue_, { src.get_count() });
-    return pr::radix_sort_indices_inplace<Float, Index>{ queue_ }(src, src_ind, deps);
+    if (device_name.find("Data Center GPU Max") != std::string::npos) {


This feels dangerous somehow. Definitely add some comments. Ideally device checking should exist as a primitive rather than in an algo because this is a bit of a nasty surprise to anyone not well-versed in this algo when trying to debug on various hardware.

@Vika-F planned to add this feature in future

icfaust · 2025-03-21T16:34:23Z

cpp/oneapi/dal/algo/decision_forest/common.cpp

@@ -61,6 +61,10 @@ class descriptor_impl : public base {
    error_metric_mode error_metric_mode_value = error_metric_mode::none;
    infer_mode infer_mode_value = infer_mode::class_responses;

+    // The default engine has been switched from mt2203 to philox for GPU,


Very good, I would love to see what this does to overall performance.

Alexandr-Solovev · 2025-03-21T19:29:58Z

/intelci: run

init adding dpl

65d9322

david-cortes-intel reviewed Jan 20, 2025

View reviewed changes

WORKSPACE Outdated Show resolved Hide resolved

Alexandr-Solovev added 11 commits January 20, 2025 06:51

fixes for dpl

f8028b7

minor fix

0b553e8

minor fix

2a91928

minor fix for dpl from toolkit

ab367c0

minor fix for script

e053cdf

minor fixes

3f1a6fe

minor fix

700cd10

minor fix

809760f

minor fix for dpl

d01ea31

fix correct link

064bb12

minor fixes

6e3587d

Alexandr-Solovev added dpc++ Issue/PR related to DPC++ functionality dependencies Pull requests that update a dependency file labels Jan 22, 2025

Alexandr-Solovev changed the title ~~init adding dpl~~ feature: enabling oneDPL and sorting primitive refactoring Jan 22, 2025

Alexandr-Solovev marked this pull request as ready for review January 22, 2025 20:28

Alexandr-Solovev requested review from Alexsandruss, samir-nasibli, napetrov, homksei, ahuber21 and ethanglaser as code owners January 22, 2025 20:28

Alexandr-Solovev changed the title ~~feature: enabling oneDPL and sorting primitive refactoring~~ feature: enabling oneDPL and sort primitive refactoring Jan 22, 2025

napetrov reviewed Jan 22, 2025

View reviewed changes

.ci/pipeline/ci.yml Outdated Show resolved Hide resolved

Alexandr-Solovev added 2 commits January 23, 2025 09:24

Merge branch 'uxlfoundation:main' into dev/asolovev_radix_sort_opt

0d9edd6

minor fix

a60eb07

Alexandr-Solovev requested a review from Vika-F as a code owner January 23, 2025 09:18

Alexandr-Solovev added 3 commits March 20, 2025 06:53

fix

5bdc11f

minor fix for docs

b027afc

minor fix

45c9f34

ethanglaser approved these changes Mar 20, 2025

View reviewed changes

cpp/oneapi/dal/algo/decision_forest/backend/gpu/train_feature_type_dpc.cpp Show resolved Hide resolved

cpp/oneapi/dal/backend/primitives/rng/device_engine_dpc.cpp Show resolved Hide resolved

fix docs

333549c

minor fix

0ceaa95

minor fix

f7c5649

ethanglaser mentioned this pull request Mar 21, 2025

Deselection for forest RNG oneDAL update uxlfoundation/scikit-learn-intelex#2370

Merged

7 tasks

Alexandr-Solovev added 2 commits March 21, 2025 09:15

fix for docs

8a71af9

Merge branch 'uxlfoundation:main' into dev/asolovev_radix_sort_opt

87fe44f

icfaust reviewed Mar 21, 2025

View reviewed changes

Alexandr-Solovev added 4 commits March 21, 2025 09:44

minor fix

34d960b

minor fix

baf774b

remove version

ec0e362

fixes

e4df736

Alexandr-Solovev merged commit 2d21aad into uxlfoundation:main Mar 21, 2025
10 of 11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature(rf optimizations): enabling oneDPL and sort primitive refactoring #3046

feature(rf optimizations): enabling oneDPL and sort primitive refactoring #3046

Alexandr-Solovev commented Jan 16, 2025 •

edited

Loading

david-cortes-intel commented Jan 20, 2025

Alexandr-Solovev commented Jan 22, 2025

Alexandr-Solovev commented Mar 20, 2025

ethanglaser commented Mar 20, 2025

ethanglaser commented Mar 20, 2025

ethanglaser left a comment

Alexandr-Solovev commented Mar 21, 2025

azure-pipelines bot commented Mar 21, 2025

Alexandr-Solovev commented Mar 21, 2025

Alexandr-Solovev commented Mar 21, 2025

ethanglaser commented Mar 21, 2025

azure-pipelines bot commented Mar 21, 2025

icfaust Mar 21, 2025

Alexandr-Solovev Mar 21, 2025

icfaust Mar 21, 2025

icfaust Mar 21, 2025

Alexandr-Solovev Mar 21, 2025

icfaust Mar 21, 2025 •

edited

Loading

Alexandr-Solovev Mar 21, 2025

icfaust Mar 21, 2025

Alexandr-Solovev commented Mar 21, 2025

feature(rf optimizations): enabling oneDPL and sort primitive refactoring #3046

feature(rf optimizations): enabling oneDPL and sort primitive refactoring #3046

Conversation

Alexandr-Solovev commented Jan 16, 2025 • edited Loading

Description:

Summary:

david-cortes-intel commented Jan 20, 2025

Alexandr-Solovev commented Jan 22, 2025

Alexandr-Solovev commented Mar 20, 2025

ethanglaser commented Mar 20, 2025

ethanglaser commented Mar 20, 2025

ethanglaser left a comment

Choose a reason for hiding this comment

Alexandr-Solovev commented Mar 21, 2025

azure-pipelines bot commented Mar 21, 2025

Alexandr-Solovev commented Mar 21, 2025

Alexandr-Solovev commented Mar 21, 2025

ethanglaser commented Mar 21, 2025

azure-pipelines bot commented Mar 21, 2025

icfaust Mar 21, 2025

Choose a reason for hiding this comment

Alexandr-Solovev Mar 21, 2025

Choose a reason for hiding this comment

icfaust Mar 21, 2025

Choose a reason for hiding this comment

icfaust Mar 21, 2025

Choose a reason for hiding this comment

Alexandr-Solovev Mar 21, 2025

Choose a reason for hiding this comment

icfaust Mar 21, 2025 • edited Loading

Choose a reason for hiding this comment

Alexandr-Solovev Mar 21, 2025

Choose a reason for hiding this comment

icfaust Mar 21, 2025

Choose a reason for hiding this comment

Alexandr-Solovev commented Mar 21, 2025

Alexandr-Solovev commented Jan 16, 2025 •

edited

Loading

icfaust Mar 21, 2025 •

edited

Loading