Skip to content

Commit

Permalink
apply review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
mcalmer authored and mackdk committed Dec 6, 2024
1 parent c124178 commit 0ba9543
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
7 changes: 0 additions & 7 deletions java/code/src/com/suse/manager/model/hub/HubFactory.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,6 @@ public class HubFactory extends HibernateFactory {

private static final Logger LOG = LogManager.getLogger(HubFactory.class);

/**
* Constructor
*/
public HubFactory() {
// TODO document why this constructor is empty
}

@Override
protected Logger getLogger() {
return LOG;
Expand Down
4 changes: 1 addition & 3 deletions java/code/src/com/suse/manager/model/hub/IssHub.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
import com.redhat.rhn.domain.BaseDomainHelper;
import com.redhat.rhn.domain.credentials.SCCCredentials;

import org.apache.commons.lang3.builder.HashCodeBuilder;

import java.util.Objects;

import javax.persistence.Column;
Expand Down Expand Up @@ -138,7 +136,7 @@ public boolean equals(Object oIn) {

@Override
public int hashCode() {
return new HashCodeBuilder().append(getFqdn()).append(getRootCa()).append(getMirrorCredentials()).toHashCode();
return Objects.hash(getFqdn(), getRootCa(), getMirrorCredentials());
}

@Override
Expand Down

0 comments on commit 0ba9543

Please sign in to comment.