Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change releasenotes URL for SUSE Multi-Linux Manager 5.1 #9825

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

mcalmer
Copy link
Contributor

@mcalmer mcalmer commented Feb 21, 2025

What does this PR change?

Change the URL for the release notes as our product get renamed to "SUSE Multi-Linux Manager".

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • Unit tests were added

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/26459
Port(s): no port - 5.1 + only

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@mcalmer mcalmer requested a review from a team as a code owner February 21, 2025 12:50
@mcalmer mcalmer requested review from rjpmestre and admd and removed request for a team February 21, 2025 12:50
@mcalmer
Copy link
Contributor Author

mcalmer commented Feb 21, 2025

@admd the URL does not exist yet. So please double check if the generated URL is right.

Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9825/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9825/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@@ -98,7 +98,7 @@ public String getReleaseNotes() {
*/
public String getReleaseNotesUrl() {
return isUyuni ? "https://www.uyuni-project.org/pages/stable-version.html" :
"https://www.suse.com/releasenotes/x86_64/SUSE-MANAGER/" +
"https://www.suse.com/releasenotes/x86_64/multi-linux-manager/" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct! This is what I agreed with @jcayouette . Thank you

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we in control of where this is created?
I thought that upload happens via buildservice and the URL is defined somehow in the product.
But ok, we will see when we upload the first version.
I would suggest we should have release notes for Beta 1 to see where the thing is created

@mcalmer mcalmer merged commit ea803cf into uyuni-project:master Feb 23, 2025
25 of 26 checks passed
@mcalmer mcalmer deleted the multi-linux-rebranding branch February 23, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants