ISSv3 - UI skeleton and Hub details page

[mackdk]

What does this PR change?

This PR adds the menu and the navigation to make the previously made pages accessible and adds the hub details page

NOTE: all the pages and the features around peripherals are included only as mock, they will be part of an additional PR.

GUI diff

After:

• DONE

Documentation

• Documentation WIP

• DONE

Test coverage

• Unit tests were added

• DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/25355

• DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

• No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

• Re-run test "changelog_test"
• Re-run test "backend_unittests_pgsql"
• Re-run test "java_pgsql_tests"
• Re-run test "schema_migration_test_pgsql"
• Re-run test "susemanager_unittests"
• Re-run test "javascript_lint"
• Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

[github-actions]

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9830/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9830/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary_parallel.yml?query=event%3Aschedule

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary.yml?query=event%3Aschedule

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

[mcalmer]

I cannot say much about typescript, but the java code is ok - just one note.
But you should check SonarCloud findings

[mcalmer]

maybe better use "hub" instead of "issv3" ?

[mackdk]

Mmm, let me double check this I don't think we should have changed it.

[mackdk]

But you should check SonarCloud findings

Those are all related to the "fake" peripheral part. I think I'll probably just remove it, so sonarcloud won't complain.

[Etheryte]

We would very much like to avoid this, if at all possible. The reason is timezones, when we start passing around native Date objects we will very quickly struggle to make any sense of what the related offsets should be.

I couldn't find the diff what we need this for, perhaps I just missed it?

[mackdk]

Ok, no problem, I changed it because I saw <FromNow /> declares it in this way, I thought it was just forgotten 😅

[mackdk]

I'm using this in the HubDetailsForm by the way, There I declare both a <FromNow /> and a <HumanDateTime /> trying to use a Date field. The former works, the latter rejects the type. That's why I changed.

[Etheryte]

Ah okay, I see, so these are values we are sending over from the server, and you want to pass those in? In that case I think it's fine, we can go ahead with this change. Essentially we want to avoid any frontend code that uses new Date() and such, and we have a linter rule for it as well, but forbidding it in many places makes it more clear that it shouldn't be done. But for receiving backend values it's fine.

[mackdk]

Yes, they come from the server JSON response as dates:

export type HubDetailData = {
  id: number;
  fqdn: string;
  rootCA: string | null;
  gpgKey: string | null;
  sccUsername: string;
  created: Date;
  modified: Date;
};

I can also convert them to Moment before passing them to the component, though.

[Etheryte]

I think for values we receive from the server it's not a problem per se because there we know what we're working with. The problem is the frontend where if you use Date and your computer timezone is different than what your server or user configuration is, then there will be an issue.

[Etheryte]

I think most places use TopPanel for this, so would be nice to use that here for consistency.

[mackdk]

I was already working on this 😅

[CDellaGiusta]

LGTM.Not an expert in typescrypt

[Etheryte]

This looks good, easy to follow along to the code and follow how it connects together. 👍