Simple fix to make items not jump if Grid is resized. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If moveAnimation = true nothing changes. If moveAnimation = false the items will not play a move animation and jump directly to the desired spots. this fixes the item jumps when the Grid component itself changes size. Could be improved by combining it with onResize listener.
|
Fix suggested in #125. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick and dirty fix for the jumping items on Grid resize problem #125.
If moveAnimation = true nothing changes.
If moveAnimation = false the items will not play a move animation and jump directly to the desired spots.
This fixes the item jumps when the Grid component itself changes size.
This also affects regular movement of components as they will now also jump to their desired spots instead of transitioning. This could be improved by combining the moveAnimation flag with on:resize listener in a more sophisticated approach.