Make the make install output less daunting

[mbaldessari]

The current output is a bit daunting for first-time users as it outputs
things like the following a few times:

customresourcedefinition.apiextensions.k8s.io/patterns.gitops.hybrid-cloud-patterns.io created
configmap/patterns-operator-config created
subscription.operators.coreos.com/patterns-operator created
error: resource mapping not found for name: "rhoai-patterns-demo" namespace: "openshift-operators" from "STDIN": no matches for kind "Pattern" in version "gitops.hybrid-cloud-patterns.io/v1alpha1"
ensure CRDs are installed first

Let's switch to something a bit more user-friendly:

make -f common/Makefile operator-deploy
make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
Checking repository:
  https://github.com/mbaldessari/multicloud-gitops.git - branch 'luis-demo': OK
Checking cluster:
  cluster-info: OK
  storageclass: WARNING: No storageclass found
Installing pattern: Done
...

Do some magic with file descriptors so we still manage to capture the
helm template stderr and the oc apply stdout+stderr and output them at
the end in case of failure.

In such cases the output will be something like the following:

Installing pattern: .....Installation failed [5/5]. Error:
Pulled: quay.io/hybridcloudpatterns/pattern-install:0.0.3
Digest: sha256:dd2d35d462b75aa8358ff278757dca0ee3c878cadafa64df8c68f880b59569ef
E1015 18:41:31.585465  196315 memcache.go:265] couldn't get current server API group list: Get "https://api.sno3.ocplab.ocp:6443/api?timeout=32s": tls: failed to verify certificate: x509: certificate signed by un
known authority (possibly because of "crypto/rsa: verification error" while trying to verify candidate authority certificate "kube-apiserver-lb-signer")
...

Suggested-by: Luis Tomas Bolivar [email protected]

[mhjacks]

If there's some kind of error without the runcount being maxed, will it be visible?

[mbaldessari]

If there's some kind of error without the runcount being maxed, will it be visible?

Yes and no. If there is an error in the first try and none in the subsequent ones we won't show it (which makes sense). If there is an error in the first try, chances are it will show up in the subsequent runs as well and it will be shown in the last one.