Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(isPhoneNumber): add validation for Macedonian [mk-MK] phone number #2500

Merged
merged 2 commits into from
Jan 30, 2025
Merged

feat(isPhoneNumber): add validation for Macedonian [mk-MK] phone number #2500

merged 2 commits into from
Jan 30, 2025

Conversation

eshward95
Copy link
Contributor

@eshward95 eshward95 commented Nov 21, 2024 •
edited
Loading

Description

  • Created a regular expression to validate Macedonian phone numbers.
  • The regex supports both international and local formats, ensuring compatibility with various phone number representations.
  • Added test cases to verify the correctness of the new regex pattern.

References:

Issue

#2497

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@eshward95 eshward95 mentioned this pull request Nov 21, 2024
Open
rubiin
rubiin previously approved these changes Nov 21, 2024
View reviewed changes
@rubiin rubiin requested a review from WikiRik November 21, 2024 13:33
@eshward95 eshward95 requested a review from rubiin November 25, 2024 16:32
@skpanagiotis skpanagiotis mentioned this pull request Jan 21, 2025
Open
@eshward95
Copy link
Contributor Author

Can we merge this PR @rubiin @pano9000 @WikiRik ?

@WikiRik WikiRik changed the title feat: Validation for macedonian [mk-MK] phone number added feat(isPhoneNumber): add validation for Macedonian [mk-MK] phone number Jan 30, 2025
@WikiRik WikiRik merged commit a7d5cff into validatorjs:master Jan 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubiin rubiin rubiin approved these changes

@WikiRik WikiRik WikiRik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eshward95 @rubiin @WikiRik