-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Add XADD command (Stream commands) #1209
Merged
Yury-Fridlyand
merged 8 commits into
valkey-io:main
from
Bit-Quill:java/integ_acarbo_add_xadd
Apr 4, 2024
Merged
Java: Add XADD command (Stream commands) #1209
Yury-Fridlyand
merged 8 commits into
valkey-io:main
from
Bit-Quill:java/integ_acarbo_add_xadd
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b6987c
to
dd26bd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transaction IT is missing
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/StreamAddOptions.java
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/StreamAddOptions.java
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/StreamAddOptions.java
Outdated
Show resolved
Hide resolved
SanHalacogluImproving
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix merge conflicts
- Transaction IT is missing. With ID option you can define the return value I think.
292a4a9
to
59c1edd
Compare
Yury-Fridlyand
approved these changes
Apr 3, 2024
Elen-Ghulam
approved these changes
Apr 4, 2024
@acarbonetto please resolve conlicts |
59c1edd
to
ba3514a
Compare
* Add Stream XADD command to Java Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
* Java: Add Zpopmax command. (Sorted Set Commands) (#149) * Minor documentation update. * Minor test update. * Spotless Signed-off-by: Andrew Carbonetto <[email protected]> * Minor documentation update. * Rebase + Spotless --------- Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
ba3514a
to
9c3a174
Compare
Yury-Fridlyand
approved these changes
Apr 4, 2024
shohamazon
pushed a commit
to adanWattad/glide-for-redis
that referenced
this pull request
Apr 9, 2024
* Java: Add XADD command (Stream commands) (valkey-io#155) Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: SanHalacogluImproving <[email protected]>
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Java: Add XADD command (Stream commands) (#155) Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: SanHalacogluImproving <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add xadd command
Example:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.