fix(tokens-info): Refactor delete missing keys for keep internal keys #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dievazqu
commented
Mar 7, 2024
| } else { | ||
| let updateRequest = data | ||
| if (overrideType.deleteMissingKeys) { | ||
| const deleteMissingKeys = deleteMissingKeysUpdateRequest( |
There was a problem hiding this comment.
The name of this might a bit misleading, but this was only removing missing keys in the root level, so basically it was removing the whole token data if not present.
dievazqu
commented
Mar 7, 2024
|
|
||
| export class OverrideType { | ||
| static readonly OverrideAll = new OverrideType(true, true) | ||
| static readonly OnlyUpdates = new OverrideType(false, false) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the tokens list, we were only adding new fields to firebase. This was to avoid overriding some fields that are updated from the price service (
historicalUsdPrices,usdPriceandpriceFetchedAt).This didn't allow us to remove fields (which is needed to disable swaps for example).
This PR changes the logic, so now we only keep some specific fields, and we remove all other unexpected fields.