Fixes #62: Sleep data / arrow 1.0 support #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per my earlier PR #64, we're attempting to get the new version merged into Home Assistant to fix #47329.
Under PR review, it came back they didn't like the pinning of arrow to a specific version number: home-assistant/core#47975 (comment)
I agree, I did that to avoid having to complete the arrow 1.0 migrations, but I should have just done the migrations from the start.
This PR update arrow to >= 1.0 and completes all the breaking change migrations they detailed here: arrow-py/arrow#832
With the new arrow 1.0 dependency version, downstream users will be able to continue using this library with python 3.9 support and be able to keep their other dependencies, like arrow, up-to-date. Thank you!