Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chronicles translation split #7

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

GeorgeK1ng
Copy link
Contributor

  1. Added support for chronicles.json in main translation and correctly list Game, Maps, Campaigns, Chronicles translation progress
  2. Improved mod translation details with real mod name, mod type and sorting

@GeorgeK1ng
Copy link
Contributor Author

How it will looks can be seen here: https://github.com/GeorgeK1ng/vcmi-translation-status but in my main branch is linked to beta branch instead of develop.

@Laserlicht
Copy link
Collaborator

Can you harmonize all translation to use chronicles.json (instead of other named jsons) then I think we could merge.

@GeorgeK1ng
Copy link
Contributor Author

GeorgeK1ng commented Feb 6, 2025

I'm working currently on another solution, which works for both methods. Just latest test needs to be done and I update PY code in this PR.

@GeorgeK1ng
Copy link
Contributor Author

Done, you can see on my main repo fullfilled Czech, German etc.. :)

@Laserlicht Laserlicht merged commit 1782a29 into vcmi:main Feb 6, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants