fix: look up selection origDef using original name not varName (#5561)

vega · Nov 17, 2019 · 50429d3 · 50429d3
1 parent 7e0dbd1
commit 50429d3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/compile/selection/parse.ts b/src/compile/selection/parse.ts
@@ -15,7 +15,7 @@ export function parseUnitSelection(model: UnitModel, selDefs: Dict<SelectionDef>
   const selCmpts: Dict<SelectionComponent<any /* this has to be "any" so typing won't fail in test files*/>> = {};
   const selectionConfig = model.config.selection;
 
-  for (let name in selDefs) {
+  for (const name in selDefs) {
     if (!hasOwnProperty(selDefs, name)) {
       continue;
     }
@@ -43,10 +43,10 @@ export function parseUnitSelection(model: UnitModel, selDefs: Dict<SelectionDef>
       }
     }
 
-    name = varName(name);
-    const selCmpt = (selCmpts[name] = {
+    const safeName = varName(name);
+    const selCmpt = (selCmpts[safeName] = {
       ...selDef,
-      name: name,
+      name: safeName,
       events: isString(selDef.on) ? parseSelector(selDef.on, 'scope') : selDef.on
     } as any);
 

diff --git a/test/compile/selection/inputs.test.ts b/test/compile/selection/inputs.test.ts
@@ -73,6 +73,14 @@ describe('Inputs Selection Transform', () => {
       fields: ['nested.a'],
       on: 'click',
       bind: {input: 'range', min: 0, max: 10, step: 1}
+    },
+    'space separated': {
+      type: 'single',
+      bind: {input: 'range', min: 0, max: 10, step: 1}
+    },
+    'dash-separated': {
+      type: 'single',
+      bind: {input: 'range', min: 0, max: 10, step: 1}
     }
   });
 
@@ -87,6 +95,8 @@ describe('Inputs Selection Transform', () => {
     expect(inputs.has(selCmpts['nine'])).toBeTruthy();
     expect(inputs.has(selCmpts['ten'])).toBeTruthy();
     expect(inputs.has(selCmpts['eleven'])).toBeTruthy();
+    expect(inputs.has(selCmpts['space_separated'])).toBeTruthy();
+    expect(inputs.has(selCmpts['dash_separated'])).toBeTruthy();
   });
 
   it('adds widget binding for default projection', () => {