Interactive Legend for Unit Specs #4732
Conversation
| if (updateValue.stroke) { | ||
| strokeValue = updateValue.stroke.value; | ||
| } | ||
| updateValue.stroke = [{test, value: strokeValue}, {value: '#aaaaaa'}]; |
There was a problem hiding this comment.
How does this work on a black background? I think we need to use a config option for these.
There was a problem hiding this comment.
I was planning to remove these hard-coded values. @domoritz what would be the best possible place in the spec to have config options such as color, opacity values or disabling interactive legends. Should this be incorporated as an optional field for every mark encoding channel?
There was a problem hiding this comment.
We should use the Vega-Lite config for this. It might make sense to have a legend property as well that allows users to override the value from the config.
domoritz
changed the title
|
It would be great to get this in. @djbarnwal are you still working on this? |
@domoritz I am waiting for a review on this. |
|
Superseded by #5305. |
A step towards Issue #1657. Continuation of PR #4317
Legends can be interacted with when the mark encoding channels completely populate the selection fields.