Fix cropdetect in ffcrt.py #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stderr to stdout
vegardsjo
approved these changes
Sep 3, 2021
|
@vegardsjo Many thanks for this port! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @vegardsjo in viler-int10h#1 (comment), the
cropdetectparsing was incomplete in theffcrt.py. I have fixed said parsing.This required modifying
run_command()to redirectstderrtostdout. I'm not sure if there's any fallout from that particular change, so more testing would be appreciated. Worse case, we add a new function for running a command with output redirected.I know @makeworld-the-better-one was also looking into fixing this, so tagging them and @viler-int10h (the original developer).