FS-29: Support iPad Presentation Size #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zac
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#29
In the context of iPad or Mac Catalyst, for a given item presented via a FlowStack, the presentation size should be constrained to a maximum width and height, mirroring the size of the built in sheet presentation for various devices and orientations.
Images
iPad Pro 12.9 in
iPad_Pro_12_flow.mp4
iPad Air
iPad_air_flow.mp4
iPad Mini
iPad_mini_flow.mp4
iPhone 15 Pro
iPhone_15_pro_flow.mp4
Mac Catalyst (scaled for iPad)
mac_catalyst_flow.mp4