feat: add shell completion for bash and zsh#924
feat: add shell completion for bash and zsh#924mifisignal wants to merge 1 commit intovercel-labs:mainfrom
Conversation
|
@mfischer-zd is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
85ea07c to
fe8c421
Compare
ctate
left a comment
There was a problem hiding this comment.
Great work — the completion scripts are thorough and the test macro that cross-checks against Rust source is a smart way to prevent drift. Three things needed before merging:
- Run
cargo fmt— several long const arrays incommands.rsexceed the line width limit, so CI will fail without this. - Add docs to
skills/agent-browser/SKILL.mdanddocs/src/app/per project convention (AGENTS.md requires all 4 doc locations updated for new user-facing commands;output.rsandREADME.mdare already done). - Typo —
completion.rs:117: "autoompletion" → "autocompletion".
Add `agent-browser completion <shell>` command that prints a shell completion script for bash or zsh. Introduce named module-level constants for every subcommand list (replacing local const blocks) so the new completion test suite can assert that each script covers all top-level commands, subcommands, and global flags.
✅ done
✅ done, with one exception: The autocomplete functionality is to assist users who are using the tool interactively in a shell, so I can't imagine a situation in which a coding agent would bother with it. In light of that, do you agree that we can skip updating the Skill?
✏️ fixed Let me know if there's anything else @ctate ! |
Add
agent-browser completion <shell>command that prints a shell completion script for bash or zsh. Introduce named module-level constants for every subcommand list (replacing local const blocks) so the new completion test suite can assert that each script covers all top-level commands, subcommands, and global flags.