fix: keep new tabs in tab_list even before URL is populated#956
Open
daidi wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: keep new tabs in tab_list even before URL is populated#956daidi wants to merge 1 commit intovercel-labs:mainfrom
daidi wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Contributor
|
@daidi is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
5ebd7dc to
3352ce7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target_info.urlis emptyTarget.targetCreatedevent handlingWhy
When a page click opens a new tab, Chromium can emit the target before URL/title are populated.
If we drop empty-URL targets,
tabmay continue to report only one tab even though the browser switched to a new tab.Regression source
This behavior appears to have been introduced by commit
8348b77(fix: filter chrome:// internal targets from auto-connect discovery), which added!url.is_empty()filtering in target collection paths.That change accidentally excluded valid newly-created tabs whose URL is not populated yet.
Repro
<a target="_blank">find text "..." clicktabBefore: sometimes only one tab is reported.
After: new tab is tracked immediately (may start with empty URL/title, later updated).
Validation
cargo checkincli/passestabreturns the second tab after new-tab click