Skip to content

chore: remove dead code and unused variables in actions.rs#961

Merged
ctate merged 3 commits intovercel-labs:mainfrom
hyunjinee:chore/remove-dead-code-actions
Mar 23, 2026
Merged

chore: remove dead code and unused variables in actions.rs#961
ctate merged 3 commits intovercel-labs:mainfrom
hyunjinee:chore/remove-dead-code-actions

Conversation

@jin-2-kakaoent
Copy link
Copy Markdown
Contributor

Summary

  • Remove daemon_state_from_env — zero call sites, logic already handled by DaemonState::new()
  • Remove resolve_semantic_locator — zero call sites, superseded by handle_semantic_locator
  • Remove unused _session_id bindings in handle_find and handle_multiselect
  • Remove no-op let _ = sid in handle_getbyrole

Net: -90 lines, no behavioral change. cargo check and cargo test pass cleanly with zero warnings.

Test plan

  • cargo check — no errors, no warnings
  • cargo test — 498 passed, 0 failed

🤖 Generated with Claude Code

Remove `daemon_state_from_env` (superseded by `DaemonState::new`) and
`resolve_semantic_locator` (superseded by `handle_semantic_locator`),
both of which had zero call sites. Also remove unused `_session_id`
bindings in `handle_find` and `handle_multiselect`, and a no-op
`let _ = sid` in `handle_getbyrole`.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 22, 2026

@hyunjinee is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@ctate
Copy link
Copy Markdown
Collaborator

ctate commented Mar 22, 2026

Thanks for the cleanup @jin-2-kakaoent. One small nit: the PR changes if let Ok(sid) to if let Ok(_sid). Since _sid is now unused, this could be simplified further to if let Ok(_).

hyunjinee and others added 2 commits March 23, 2026 09:11
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jin-2-kakaoent
Copy link
Copy Markdown
Contributor Author

@ctate

Thanks for the feedback! Updated _sid → is_ok() in 1740081. Went one step further than if let Ok(_) since Clippy flags that pattern as redundant_pattern_matching.

@ctate ctate merged commit d374e41 into vercel-labs:main Mar 23, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants