fix: prevent state commands from starting daemon without session_name (#677)

[jin-2-kakaoent]

Summary

Fixes #677

--session-name / AGENT_BROWSER_SESSION_NAME does not persist cookies or localStorage across restarts when a state management command (e.g. state clear --all) starts the daemon before the session name is set.

Root Cause

AS-IS (Before)

session_name is only passed to the daemon via environment variable at daemon spawn time. Once the daemon is running, there is no way to update its session_name.

sequenceDiagram
    participant Shell
    participant CLI
    participant Daemon
    participant Browser

    Note over Shell: SESSION_NAME not yet exported

    Shell->>CLI: agent-browser state clear --all
    CLI->>Daemon: ensure_daemon() → spawns daemon
    Note over Daemon: session_name = None ❌<br/>(env var not set at spawn time)
    Daemon-->>CLI: Done

    Note over Shell: export SESSION_NAME=my-session

    Shell->>CLI: agent-browser open https://example.com
    CLI->>Daemon: reuse running daemon (already_running=true)
    Note over Daemon: session_name = still None ❌
    Daemon->>Browser: launch + navigate

    Shell->>CLI: agent-browser eval 'localStorage.setItem(...)'
    CLI->>Daemon: evaluate
    Daemon->>Browser: set cookie + localStorage ✅

    Shell->>CLI: agent-browser close
    CLI->>Daemon: close
    Note over Daemon: handle_close():<br/>if session_name.is_some() → FALSE<br/>→ state save SKIPPED ❌
    Daemon->>Browser: Browser.close

    Shell->>CLI: agent-browser open https://example.com
    CLI->>Daemon: ensure_daemon() → new daemon
    Note over Daemon: session_name = "my-session" ✅<br/>(env var now set)
    Note over Daemon: looks for state file → NOT FOUND ❌
    Daemon->>Browser: launch (no restoration)

    Shell->>CLI: agent-browser eval 'localStorage.getItem(...)'
    Daemon->>Browser: evaluate
    Browser-->>CLI: null ❌

Loading

The commands state_list, state_show, state_clear, state_clean, and state_rename are pure file operations that don't need a browser or daemon. Yet they were routed through ensure_daemon(), which could start a daemon without session_name.

TO-BE (After)

State management commands are now executed locally in the CLI process before ensure_daemon() is called.

sequenceDiagram
    participant Shell
    participant CLI
    participant Daemon
    participant Browser

    Note over Shell: SESSION_NAME not yet exported

    Shell->>CLI: agent-browser state clear --all
    Note over CLI: dispatch_state_command()<br/>→ local file operation<br/>→ daemon NOT started ✅
    CLI-->>Shell: Done

    Note over Shell: export SESSION_NAME=my-session

    Shell->>CLI: agent-browser open https://example.com
    CLI->>Daemon: ensure_daemon() → spawns daemon
    Note over Daemon: session_name = "my-session" ✅<br/>(env var set before first daemon start)
    Daemon->>Browser: launch + navigate

    Shell->>CLI: agent-browser eval 'localStorage.setItem(...)'
    CLI->>Daemon: evaluate
    Daemon->>Browser: set cookie + localStorage ✅

    Shell->>CLI: agent-browser close
    CLI->>Daemon: close
    Note over Daemon: handle_close():<br/>session_name = Some("my-session") ✅<br/>→ saves cookies + localStorage
    Daemon->>Browser: Browser.close

    Shell->>CLI: agent-browser open https://example.com
    CLI->>Daemon: ensure_daemon() → new daemon
    Note over Daemon: finds state file → restores data ✅
    Daemon->>Browser: launch + restore

    Shell->>CLI: agent-browser eval 'localStorage.getItem(...)'
    Daemon->>Browser: evaluate
    Browser-->>CLI: "ok" ✅

Loading

Test Plan

• cargo test — 503 passed, 0 failed
• Unit tests for dispatch_state_command: routing, None for unknown, missing params
• Manual E2E verification:

  # This flow was broken before the fix:
  agent-browser state clear --all
  export AGENT_BROWSER_SESSION_NAME=test-session
  agent-browser open https://httpbin.org/html
  agent-browser eval 'localStorage.setItem("key","value"); document.cookie="c=1; max-age=3600; path=/"'
  agent-browser close
  sleep 2
  agent-browser open https://httpbin.org/html
  agent-browser eval 'JSON.stringify({ls: localStorage.getItem("key"), cookie: document.cookie})'
  # Before: {"ls":null,"cookie":""}
  # After:  {"ls":"value","cookie":"c=1"}

• Verified state clear no longer starts a daemon process
• Verified daemon-path state commands still work (batch/IPC)

🤖 Generated with Claude Code

[vercel]

@hyunjinee is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.