fix: resolve typecheck errors - add DOM lib and HTMLElement cast#967
Open
maomaohz wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: resolve typecheck errors - add DOM lib and HTMLElement cast#967maomaohz wants to merge 1 commit intovercel-labs:mainfrom
maomaohz wants to merge 1 commit intovercel-labs:mainfrom
Conversation
- Add "DOM" to tsconfig lib for HTMLElement.scrollBy support - Cast element to HTMLElement in scrollBy call (not available on SVGElement) Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
|
@maomaohz is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
git fetch vercel-labs |
1 similar comment
Author
|
git fetch vercel-labs |
maomaohz
commented
Mar 23, 2026
Author
maomaohz
left a comment
maomaohz
left a comment
There was a problem hiding this comment.
PR 信息：
- Title: fix: resolve typecheck errors
- Body:
Summary
- Add "DOM" to tsconfig lib for HTMLElement.scrollBy support
- Cast element to HTMLElement in scrollBy call (not available on SVGElement)
Test plan
- Run
npm run typecheck- passes - Run
npm test- 171 passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git checkout fix/typecheck-scrollby
git rebase vercel-labs/main
git push -f fork fix/typecheck-scrollby