fix: dangling not-found returns in action-handler

[lubieowoce]

there's a bunch of return { type: 'not-found' } bits whose return value was never used. probably broke in a refactor that wrapped stuff in actionAsyncStorage.run(..., () => { ... }), which meant that these early returns were breaking out of the inner closure, not handleAction itself.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js lubieowoce/action-handler-dangling-returns	Change
buildDuration	20s	18.4s	N/A
buildDurationCached	17.1s	14.4s	N/A
nodeModulesSize	392 MB	392 MB	⚠️ +14.1 kB
nextStartRea..uration (ms)	464ms	466ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js lubieowoce/action-handler-dangling-returns	Change
5306-HASH.js gzip	54 kB	54 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	52.9 kB	52.9 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	240 B	242 B	N/A
main-HASH.js gzip	34.5 kB	34.5 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js lubieowoce/action-handler-dangling-returns	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js lubieowoce/action-handler-dangling-returns	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js lubieowoce/action-handler-dangling-returns	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js lubieowoce/action-handler-dangling-returns	Change
index.html gzip	523 B	523 B	✓
link.html gzip	538 B	538 B	✓
withRouter.html gzip	519 B	520 B	N/A
Overall change	1.06 kB	1.06 kB	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js lubieowoce/action-handler-dangling-returns	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	210 kB	210 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js lubieowoce/action-handler-dangling-returns	Change
middleware-b..fest.js gzip	674 B	674 B	✓
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	1.52 kB	1.52 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js lubieowoce/action-handler-dangling-returns	Change
app-page-exp...dev.js gzip	393 kB	393 kB	N/A
app-page-exp..prod.js gzip	132 kB	132 kB	N/A
app-page-tur..prod.js gzip	145 kB	145 kB	N/A
app-page-tur..prod.js gzip	141 kB	141 kB	N/A
app-page.run...dev.js gzip	380 kB	380 kB	N/A
app-page.run..prod.js gzip	128 kB	128 kB	N/A
app-route-ex...dev.js gzip	39.3 kB	39.3 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	40.8 kB	40.8 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	31.5 kB	31.5 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	60.5 kB	60.5 kB	✓
Overall change	350 kB	350 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js lubieowoce/action-handler-dangling-returns	Change
0.pack gzip	2.1 MB	2.11 MB	⚠️ +3.76 kB
index.pack gzip	76.3 kB	75.7 kB	N/A
Overall change	2.1 MB	2.11 MB	⚠️ +3.76 kB

Diff details

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Commit: db5b635

[ijjk]

Failing test suites

Commit: db5b635

pnpm test-start test/e2e/app-dir/actions/app-action.test.ts

• app-dir action handling > redirects > redirects properly when server action handler redirects with a 307 status code
• app-dir action handling > redirects > redirects properly when server action handler redirects with a 308 status code

Expand output

● app-dir action handling › redirects › redirects properly when server action handler redirects with a 307 status code

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#redirect-page')

  430 |     return this.chain(() => {
  431 |       return page
> 432 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  433 |         .then(async (el) => {
  434 |           // it seems selenium waits longer and tests rely on this behavior
  435 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:432:10)
  at BrowserInterface.chain (lib/browsers/base.ts:17:23)
  at BrowserInterface.chain [as waitForElementByCss] (lib/browsers/playwright.ts:430:17)
  at BrowserInterface.waitForElementByCss [as elementByCss] (lib/browsers/playwright.ts:350:17)
  at BrowserInterface.elementByCss [as elementById] (lib/browsers/playwright.ts:354:17)
  at elementById (e2e/app-dir/actions/app-action.test.ts:1759:30)

● app-dir action handling › redirects › redirects properly when server action handler redirects with a 308 status code

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#redirect-page')

  430 |     return this.chain(() => {
  431 |       return page
> 432 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  433 |         .then(async (el) => {
  434 |           // it seems selenium waits longer and tests rely on this behavior
  435 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:432:10)
  at BrowserInterface.chain (lib/browsers/base.ts:17:23)
  at BrowserInterface.chain [as waitForElementByCss] (lib/browsers/playwright.ts:430:17)
  at BrowserInterface.waitForElementByCss [as elementByCss] (lib/browsers/playwright.ts:350:17)
  at BrowserInterface.elementByCss [as elementById] (lib/browsers/playwright.ts:354:17)
  at elementById (e2e/app-dir/actions/app-action.test.ts:1759:30)

Read more about building and testing Next.js in contributing.md.