fix(web): injectSpeedInsights requires a parameter value #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
feugy
deleted the
damien/aly-1166-injectspeedinsights-should-allow-no-parameters
branch
renovate bot
referenced
this pull request
in inabagumi/shinju-date
Jan 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vercel/speed-insights](https://togithub.com/vercel/speed-insights) ([source](https://togithub.com/vercel/speed-insights/tree/HEAD/packages/web)) | [`^1.0.2` -> `^1.0.3`](https://renovatebot.com/diffs/npm/@vercel%2fspeed-insights/1.0.2/1.0.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/speed-insights (@​vercel/speed-insights)</summary> ### [`v1.0.3`](https://togithub.com/vercel/speed-insights/releases/tag/1.0.3) [Compare Source](https://togithub.com/vercel/speed-insights/compare/1.0.2...1.0.3) #### What's Changed - fix(web): injectSpeedInsights requires a parameter value by [@​feugy](https://togithub.com/feugy) in [https://github.com/vercel/speed-insights/pull/38](https://togithub.com/vercel/speed-insights/pull/38) **Full Changelog**: vercel/speed-insights@1.0.2...1.0.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/inabagumi/shinju-date). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in ziyadedher/ziyadedher
Jan 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vercel/speed-insights](https://togithub.com/vercel/speed-insights) ([source](https://togithub.com/vercel/speed-insights/tree/HEAD/packages/web)) | [`1.0.2` -> `1.0.3`](https://renovatebot.com/diffs/npm/@vercel%2fspeed-insights/1.0.2/1.0.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/speed-insights (@​vercel/speed-insights)</summary> ### [`v1.0.3`](https://togithub.com/vercel/speed-insights/releases/tag/1.0.3) [Compare Source](https://togithub.com/vercel/speed-insights/compare/1.0.2...1.0.3) #### What's Changed - fix(web): injectSpeedInsights requires a parameter value by [@​feugy](https://togithub.com/feugy) in [https://github.com/vercel/speed-insights/pull/38](https://togithub.com/vercel/speed-insights/pull/38) **Full Changelog**: vercel/speed-insights@1.0.2...1.0.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ziyadedher/ziyadedher). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in ziyadedher/dental-clutter
Jan 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vercel/speed-insights](https://togithub.com/vercel/speed-insights) ([source](https://togithub.com/vercel/speed-insights/tree/HEAD/packages/web)) | [`1.0.2` -> `1.0.3`](https://renovatebot.com/diffs/npm/@vercel%2fspeed-insights/1.0.2/1.0.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/speed-insights (@​vercel/speed-insights)</summary> ### [`v1.0.3`](https://togithub.com/vercel/speed-insights/releases/tag/1.0.3) [Compare Source](https://togithub.com/vercel/speed-insights/compare/1.0.2...1.0.3) #### What's Changed - fix(web): injectSpeedInsights requires a parameter value by [@​feugy](https://togithub.com/feugy) in [https://github.com/vercel/speed-insights/pull/38](https://togithub.com/vercel/speed-insights/pull/38) **Full Changelog**: vercel/speed-insights@1.0.2...1.0.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ziyadedher/dental-clutter). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kodiakhq bot
referenced
this pull request
in weareinreach/TransMascFutures
Jan 13, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@storybook/addon-a11y](https://togithub.com/storybookjs/storybook/tree/next/code/addons/a11y) ([source](https://togithub.com/storybookjs/storybook/tree/HEAD/code/addons/a11y)) | [`7.6.7` -> `7.6.8`](https://renovatebot.com/diffs/npm/@storybook%2faddon-a11y/7.6.7/7.6.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-essentials](https://togithub.com/storybookjs/storybook/tree/next/code/addons/essentials) ([source](https://togithub.com/storybookjs/storybook/tree/HEAD/code/addons/essentials)) | [`7.6.7` -> `7.6.8`](https://renovatebot.com/diffs/npm/@storybook%2faddon-essentials/7.6.7/7.6.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-interactions](https://togithub.com/storybookjs/storybook/tree/next/code/addons/interactions) ([source](https://togithub.com/storybookjs/storybook/tree/HEAD/code/addons/interactions)) | [`7.6.7` -> `7.6.8`](https://renovatebot.com/diffs/npm/@storybook%2faddon-interactions/7.6.7/7.6.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-links](https://togithub.com/storybookjs/storybook/tree/next/code/addons/links) ([source](https://togithub.com/storybookjs/storybook/tree/HEAD/code/addons/links)) | [`7.6.7` -> `7.6.8`](https://renovatebot.com/diffs/npm/@storybook%2faddon-links/7.6.7/7.6.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-viewport](https://togithub.com/storybookjs/storybook/tree/next/code/addons/viewport) ([source](https://togithub.com/storybookjs/storybook/tree/HEAD/code/addons/viewport)) | [`7.6.7` -> `7.6.8`](https://renovatebot.com/diffs/npm/@storybook%2faddon-viewport/7.6.7/7.6.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/blocks](https://togithub.com/storybookjs/storybook/tree/next/code/ui/blocks) ([source](https://togithub.com/storybookjs/storybook/tree/HEAD/code/ui/blocks)) | [`7.6.7` -> `7.6.8`](https://renovatebot.com/diffs/npm/@storybook%2fblocks/7.6.7/7.6.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/nextjs](https://togithub.com/storybookjs/storybook/tree/next/code/frameworks/nextjs) ([source](https://togithub.com/storybookjs/storybook/tree/HEAD/code/frameworks/nextjs)) | [`7.6.7` -> `7.6.8`](https://renovatebot.com/diffs/npm/@storybook%2fnextjs/7.6.7/7.6.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/react](https://togithub.com/storybookjs/storybook/tree/next/code/renderers/react) ([source](https://togithub.com/storybookjs/storybook/tree/HEAD/code/renderers/react)) | [`7.6.7` -> `7.6.8`](https://renovatebot.com/diffs/npm/@storybook%2freact/7.6.7/7.6.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@tabler/icons-react](https://tabler-icons.io) ([source](https://togithub.com/tabler/tabler-icons/tree/HEAD/packages/icons-react)) | [`2.45.0` -> `2.46.0`](https://renovatebot.com/diffs/npm/@tabler%2ficons-react/2.45.0/2.46.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@vercel/speed-insights](https://togithub.com/vercel/speed-insights) ([source](https://togithub.com/vercel/speed-insights/tree/HEAD/packages/web)) | [`1.0.2` -> `1.0.3`](https://renovatebot.com/diffs/npm/@vercel%2fspeed-insights/1.0.2/1.0.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [chromatic](https://www.chromatic.com) ([source](https://togithub.com/chromaui/chromatic-cli)) | [`10.2.1` -> `10.2.2`](https://renovatebot.com/diffs/npm/chromatic/10.2.1/10.2.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [prettier](https://prettier.io) ([source](https://togithub.com/prettier/prettier)) | [`3.1.1` -> `3.2.1`](https://renovatebot.com/diffs/npm/prettier/3.1.1/3.2.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [storybook](https://togithub.com/storybookjs/storybook/tree/next/code/lib/cli) ([source](https://togithub.com/storybookjs/storybook/tree/HEAD/code/lib/cli)) | [`7.6.7` -> `7.6.8`](https://renovatebot.com/diffs/npm/storybook/7.6.7/7.6.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>storybookjs/storybook (@​storybook/addon-a11y)</summary> ### [`v7.6.8`](https://togithub.com/storybookjs/storybook/blob/HEAD/CHANGELOG.md#768) [Compare Source](https://togithub.com/storybookjs/storybook/compare/v7.6.7...v7.6.8) - Addon-actions: Fix module resolution for react-native - [#​25296](https://togithub.com/storybookjs/storybook/pull/25296), thanks [@​dannyhw](https://togithub.com/dannyhw)! - Storysource: Fix import error - [#​25391](https://togithub.com/storybookjs/storybook/pull/25391), thanks [@​unional](https://togithub.com/unional)! </details> <details> <summary>storybookjs/storybook (@​storybook/addon-interactions)</summary> ### [`v7.6.8`](https://togithub.com/storybookjs/storybook/compare/v7.6.7...2eded2e062ff7f984706a066090b7c699ee5c71e) [Compare Source](https://togithub.com/storybookjs/storybook/compare/v7.6.7...v7.6.8) </details> <details> <summary>tabler/tabler-icons (@​tabler/icons-react)</summary> ### [`v2.46.0`](https://togithub.com/tabler/tabler-icons/releases/tag/v2.46.0): Release 2.46.0 [Compare Source](https://togithub.com/tabler/tabler-icons/compare/v2.45.0...v2.46.0) <img src="https://github.com/tabler/tabler-icons/assets/1282324/9895fb5c-517e-4ae1-bb84-f5728e1a8483" width="584" alt="" /> ##### 18 new icons: - `arrow-down-from-arc` - `arrow-down-to-arc` - `arrow-left-from-arc` - `arrow-left-to-arc` - `arrow-right-from-arc` - `arrow-right-to-arc` - `arrow-up-from-arc` - `arrow-up-to-arc` - `avocado` - `badge-ad-off` - `bowl-chopsticks` - `bowl-spoon` - `chart-scatter-3d` - `chart-scatter` - `sort-ascending-shapes` - `sort-ascending-small-big` - `sort-deacending-small-big` - `sort-descending-shapes` Fixed icons: `circle-dashed-percentage`, `circle-percentage`, `square-percentage`, `square-rounded-percentage` </details> <details> <summary>vercel/speed-insights (@​vercel/speed-insights)</summary> ### [`v1.0.3`](https://togithub.com/vercel/speed-insights/releases/tag/1.0.3) [Compare Source](https://togithub.com/vercel/speed-insights/compare/1.0.2...1.0.3) #### What's Changed - fix(web): injectSpeedInsights requires a parameter value by [@​feugy](https://togithub.com/feugy) in [https://github.com/vercel/speed-insights/pull/38](https://togithub.com/vercel/speed-insights/pull/38) **Full Changelog**: vercel/speed-insights@1.0.2...1.0.3 </details> <details> <summary>chromaui/chromatic-cli (chromatic)</summary> ### [`v10.2.2`](https://togithub.com/chromaui/chromatic-cli/blob/HEAD/CHANGELOG.md#v1022-Fri-Jan-12-2024) [Compare Source](https://togithub.com/chromaui/chromatic-cli/compare/v10.2.1...v10.2.2) ##### 🐛 Bug Fix - Add configFile option to GitHub Action [#​885](https://togithub.com/chromaui/chromatic-cli/pull/885) ([@​wisestuart](https://togithub.com/wisestuart)) ##### Authors: 1 - Stuart Hammar ([@​wisestuart](https://togithub.com/wisestuart)) *** </details> <details> <summary>prettier/prettier (prettier)</summary> ### [`v3.2.1`](https://togithub.com/prettier/prettier/blob/HEAD/CHANGELOG.md#321) [Compare Source](https://togithub.com/prettier/prettier/compare/3.2.0...3.2.1) [diff](https://togithub.com/prettier/prettier/compare/3.2.0...3.2.1) ##### Fix formatting error on member chain ([#​15915](https://togithub.com/prettier/prettier/pull/15915) by [@​sosukesuzuki](https://togithub.com/sosukesuzuki)) ```jsx // Input test().test2().test2(thing?.something); // Prettier 3.2.0 TypeError: Cannot read properties of undefined (reading 'type') // Prettier 3.2.1 test().test2().test2(thing?.something); ``` ### [`v3.2.0`](https://togithub.com/prettier/prettier/blob/HEAD/CHANGELOG.md#320) [Compare Source](https://togithub.com/prettier/prettier/compare/3.1.1...3.2.0) [diff](https://togithub.com/prettier/prettier/compare/3.1.1...3.2.0) 🔗 [Release Notes](https://prettier.io/blog/2024/01/13/3.2.0.html) </details> <details> <summary>storybookjs/storybook (storybook)</summary> ### [`v7.6.8`](https://togithub.com/storybookjs/storybook/compare/v7.6.7...2eded2e062ff7f984706a066090b7c699ee5c71e) [Compare Source](https://togithub.com/storybookjs/storybook/compare/v7.6.7...v7.6.8) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/weareinreach/GLAAD). PR-URL: #309 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in simonknittel/sinister-incorporated
Jan 20, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vercel/speed-insights](https://togithub.com/vercel/speed-insights) ([source](https://togithub.com/vercel/speed-insights/tree/HEAD/packages/web)) | [`1.0.2` -> `1.0.3`](https://renovatebot.com/diffs/npm/@vercel%2fspeed-insights/1.0.2/1.0.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/speed-insights (@​vercel/speed-insights)</summary> ### [`v1.0.3`](https://togithub.com/vercel/speed-insights/releases/tag/1.0.3) [Compare Source](https://togithub.com/vercel/speed-insights/compare/1.0.2...1.0.3) #### What's Changed - fix(web): injectSpeedInsights requires a parameter value by [@​feugy](https://togithub.com/feugy) in [https://github.com/vercel/speed-insights/pull/38](https://togithub.com/vercel/speed-insights/pull/38) **Full Changelog**: vercel/speed-insights@1.0.2...1.0.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/simonknittel/sinister-incorporated). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 What's in there?
Fixes #32, #34
There's no strong reason for forcing users to provide a framework when they directly use
injectSpeedInsights().This PR sets a default empty value.
🧪 How to test?
Some new unit tests:
pnpm t❗ Notes to reviewers
I added very basic unit tests for this change, which will make it easier in the future for writing other, more valuable tests.
All tests are running in jsdom environment, except one, which uses node environment, to simulate server-side rendering.
This forced me to adjust the
beforeEach()inpackages/web/jest.setup.ts.On my VSCode I'm getting many
Unsafe call of ananytyped value.eslint@typescript-eslint/no-unsafe-callerrors in test files, which we don't see when runningpnpm -F @vercel/speed-insights lintIs it the same for you @tobiaslins?
I updated a couple types, but it didn't solved it.