fix: astro check fails on @vercel/speed-insights/astro missing types #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tobiaslins
approved these changes
Jan 16, 2024
feugy
deleted the
damien/aly-1169-speed-insights-astro-component-does-not-pass-astro-check
branch
renovate bot
referenced
this pull request
in inabagumi/shinju-date
Jan 16, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vercel/speed-insights](https://togithub.com/vercel/speed-insights) ([source](https://togithub.com/vercel/speed-insights/tree/HEAD/packages/web)) | [`^1.0.3` -> `^1.0.4`](https://renovatebot.com/diffs/npm/@vercel%2fspeed-insights/1.0.3/1.0.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/speed-insights (@​vercel/speed-insights)</summary> ### [`v1.0.4`](https://togithub.com/vercel/speed-insights/releases/tag/1.0.4) [Compare Source](https://togithub.com/vercel/speed-insights/compare/1.0.3...1.0.4) #### What's Changed - fix: astro check fails on @​vercel/speed-insights/astro missing types by [@​feugy](https://togithub.com/feugy) in [https://github.com/vercel/speed-insights/pull/41](https://togithub.com/vercel/speed-insights/pull/41) **Full Changelog**: vercel/speed-insights@1.0.3...1.0.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/inabagumi/shinju-date). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in ziyadedher/dental-clutter
Jan 16, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vercel/speed-insights](https://togithub.com/vercel/speed-insights) ([source](https://togithub.com/vercel/speed-insights/tree/HEAD/packages/web)) | [`1.0.3` -> `1.0.4`](https://renovatebot.com/diffs/npm/@vercel%2fspeed-insights/1.0.3/1.0.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/speed-insights (@​vercel/speed-insights)</summary> ### [`v1.0.4`](https://togithub.com/vercel/speed-insights/releases/tag/1.0.4) [Compare Source](https://togithub.com/vercel/speed-insights/compare/1.0.3...1.0.4) #### What's Changed - fix: astro check fails on @​vercel/speed-insights/astro missing types by [@​feugy](https://togithub.com/feugy) in [https://github.com/vercel/speed-insights/pull/41](https://togithub.com/vercel/speed-insights/pull/41) **Full Changelog**: vercel/speed-insights@1.0.3...1.0.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ziyadedher/dental-clutter). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in ziyadedher/ziyadedher
Jan 16, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vercel/speed-insights](https://togithub.com/vercel/speed-insights) ([source](https://togithub.com/vercel/speed-insights/tree/HEAD/packages/web)) | [`1.0.3` -> `1.0.4`](https://renovatebot.com/diffs/npm/@vercel%2fspeed-insights/1.0.3/1.0.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/speed-insights (@​vercel/speed-insights)</summary> ### [`v1.0.4`](https://togithub.com/vercel/speed-insights/releases/tag/1.0.4) [Compare Source](https://togithub.com/vercel/speed-insights/compare/1.0.3...1.0.4) #### What's Changed - fix: astro check fails on @​vercel/speed-insights/astro missing types by [@​feugy](https://togithub.com/feugy) in [https://github.com/vercel/speed-insights/pull/41](https://togithub.com/vercel/speed-insights/pull/41) **Full Changelog**: vercel/speed-insights@1.0.3...1.0.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ziyadedher/ziyadedher). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kodiakhq bot
referenced
this pull request
in weareinreach/TransMascFutures
Jan 16, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | [`20.11.3` -> `20.11.4`](https://renovatebot.com/diffs/npm/@types%2fnode/20.11.3/20.11.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@vercel/speed-insights](https://togithub.com/vercel/speed-insights) ([source](https://togithub.com/vercel/speed-insights/tree/HEAD/packages/web)) | [`1.0.3` -> `1.0.4`](https://renovatebot.com/diffs/npm/@vercel%2fspeed-insights/1.0.3/1.0.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [chromatic](https://www.chromatic.com) ([source](https://togithub.com/chromaui/chromatic-cli)) | [`10.2.2` -> `10.3.0`](https://renovatebot.com/diffs/npm/chromatic/10.2.2/10.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/speed-insights (@​vercel/speed-insights)</summary> ### [`v1.0.4`](https://togithub.com/vercel/speed-insights/releases/tag/1.0.4) [Compare Source](https://togithub.com/vercel/speed-insights/compare/1.0.3...1.0.4) #### What's Changed - fix: astro check fails on @​vercel/speed-insights/astro missing types by [@​feugy](https://togithub.com/feugy) in [https://github.com/vercel/speed-insights/pull/41](https://togithub.com/vercel/speed-insights/pull/41) **Full Changelog**: vercel/speed-insights@1.0.3...1.0.4 </details> <details> <summary>chromaui/chromatic-cli (chromatic)</summary> ### [`v10.3.0`](https://togithub.com/chromaui/chromatic-cli/blob/HEAD/CHANGELOG.md#v1030-Tue-Jan-16-2024) [Compare Source](https://togithub.com/chromaui/chromatic-cli/compare/v10.2.2...v10.3.0) ##### 🚀 Enhancement - Add missing `skip` option to configuration schema [#​890](https://togithub.com/chromaui/chromatic-cli/pull/890) ([@​ghengeveld](https://togithub.com/ghengeveld)) - Detect merge queue branch and retrieve real branch name from pull request [#​884](https://togithub.com/chromaui/chromatic-cli/pull/884) ([@​JonathanKolnik](https://togithub.com/JonathanKolnik) [@​ghengeveld](https://togithub.com/ghengeveld)) - Deduplicate files to be uploaded using file hashing [#​875](https://togithub.com/chromaui/chromatic-cli/pull/875) ([@​ghengeveld](https://togithub.com/ghengeveld)) - Replace upload mechanism to use a batched mutation with a new API [#​888](https://togithub.com/chromaui/chromatic-cli/pull/888) ([@​ghengeveld](https://togithub.com/ghengeveld)) ##### 🐛 Bug Fix - Retrieve `sentinelUrls` from `uploadBuild` and wait for all of them before finishing upload task [#​878](https://togithub.com/chromaui/chromatic-cli/pull/878) ([@​ghengeveld](https://togithub.com/ghengeveld)) ##### Authors: 2 - Gert Hengeveld ([@​ghengeveld](https://togithub.com/ghengeveld)) - Jono Kolnik ([@​JonathanKolnik](https://togithub.com/JonathanKolnik)) *** </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/weareinreach/GLAAD). PR-URL: #311 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in simonknittel/sinister-incorporated
Jan 23, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vercel/speed-insights](https://togithub.com/vercel/speed-insights) ([source](https://togithub.com/vercel/speed-insights/tree/HEAD/packages/web)) | [`1.0.3` -> `1.0.4`](https://renovatebot.com/diffs/npm/@vercel%2fspeed-insights/1.0.3/1.0.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/speed-insights (@​vercel/speed-insights)</summary> ### [`v1.0.4`](https://togithub.com/vercel/speed-insights/releases/tag/1.0.4) [Compare Source](https://togithub.com/vercel/speed-insights/compare/1.0.3...1.0.4) #### What's Changed - fix: astro check fails on @​vercel/speed-insights/astro missing types by [@​feugy](https://togithub.com/feugy) in [https://github.com/vercel/speed-insights/pull/41](https://togithub.com/vercel/speed-insights/pull/41) **Full Changelog**: vercel/speed-insights@1.0.3...1.0.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/simonknittel/sinister-incorporated). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 What's in there?
Fixes #36. It is not possible yet to publish types along an Astro component, and the
astro checkcommand will fail on it.As per the Astro team recommendations, we need to specify a file for types, even if it does not exist.
🧪 How to test?
pnpm -F @vercel/speed-insights buildcd apps/astropnpm i -D typescript @astrojs/checkpnpm exec astro check: it will work, while it used to fail with error:Note: there is still a warning about
speedInsightsBeforeSend()unused function, but I couldn't get rid of it.