fix: handle s3 errors without a status code #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an error occurs with the SDK before an HTTP request is made then the error's statusCode will be `undefined`, which will trigger a TypeError in common code outside the plugin. This change sets a fallback 500 status code so that error handling can continue.
barrywoolgar
changed the title
juanpicado
approved these changes
Feb 17, 2024
|
ref #704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Bug
Scope: verdaccio-aws-s3-storage
The following has been addressed in the PR:
undefined, which will trigger a TypeError in common code outside the plugin, masking the true error (eg. missing AWS credentials)This change sets a fallback 500 status code so that error handling will continue.
Resolves #695