Skip to content

Typos and Noop Default in Callback #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SSoelvsten
Copy link
Contributor

  • Fixes spelling error of unknown (the second n is missing); this is a breaking change.
  • Fixes some spelling errors in comments.
  • Makes the default implementation of the Callback class lots of noops. This way, one only has to overload/implement the few relevant functions.

This makes the derived code much cleaner, since boiler plate code is omitted
@vaughnbetz
Copy link
Contributor

Thanks, and sorry I didn't notice this until now. When you say this is a breaking change, does anything in VTR (users of the parser) break?

@vaughnbetz
Copy link
Contributor

@soheilshahrouz : while you're checking out the make format on libblifparse, could you also test this change works fine with VTR? If so I'll merge it.

@SSoelvsten
Copy link
Contributor Author

SSoelvsten commented Nov 1, 2024

No worries about the delay; thanks for this parser - it has been great help for my research. 🙂 If a user of the parser makes use of the LogicValue enum (which I'd imagine they would), then compilation breaks. If bumping the major version number is not desirable, then one can exclusively merge 9771095 in instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants