Skip to content

Change QoR parsing configs to use the fixed channel width variant #3138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

AmirhosseinPoolad
Copy link
Contributor

Changes the parse_file attribute of tests that use fixed channel widths instead of doing the minimum channel width search to use vpr_fixed_chan_width.txt instead of vpr_standard.txt

(Don't merge yet, planning to use CI artifacts to test)

Changes the parse_file attribute of tests that use fixed channel widths instead of doing the minimum channel width search to use vpr_fixed_chan_width.txt instead of vpr_standard.txt
@AmirhosseinPoolad AmirhosseinPoolad force-pushed the fixed_channel_parse_fix branch from d622e75 to cf091b6 Compare June 12, 2025 21:04
@AmirhosseinPoolad
Copy link
Contributor Author

AmirhosseinPoolad commented Jun 12, 2025

Since the parse_results.txt for some of the tests are going to be different, I need to update golden results for those tests. Here's a checklist to make sure I don't forget anything.

  • vtr_reg_strong
  • vtr_reg_strong_odin
  • vtr_reg_nightly_test1 (Did not actually regenerated anything. Only changed task was symbiflow but the test does not work and isn't in the tasklist)
  • vtr_reg_nightly_test1_odin (Same as above)
  • vtr_reg_nightly_test2
  • vtr_reg_nightly_test2_odin
  • vtr_reg_nightly_test4
  • vtr_reg_nightly_test4_odin
  • vtr_reg_nightly_test5
  • vtr_reg_nightly_test6
  • vtr_reg_valgrind (No pass requirements)
  • vtr_reg_weekly

@github-actions github-actions bot added the infra Project Infrastructure label Jun 12, 2025
@AmirhosseinPoolad
Copy link
Contributor Author

AmirhosseinPoolad commented Jun 12, 2025

Sorry to hijack the PR but since this is going to require regenerating a ton of golden results I made NightlyTestManual generate and upload them. I can remove the commit if you disagree. @AlexandreSinger FYI.

@AlexandreSinger
Copy link
Contributor

No worries @AmirhosseinPoolad , no one appears to be using it! Do please also update the golden results for some of the failing nightly tests while you are at it! 2 small ones were failing before! If not do not worry about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Project Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants