Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/rest chunk upload #1068

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Test/rest chunk upload #1068

merged 1 commit into from
Feb 13, 2025

Conversation

lrm25
Copy link
Contributor

@lrm25 lrm25 commented Feb 11, 2025

No description provided.

@lrm25 lrm25 force-pushed the test/rest_chunk_upload branch from e58b6cd to 2257281 Compare February 12, 2025 18:28
Copy link

@anodelman anodelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit.

fi
fi

# shellcheck disable=SC2119

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you removed the rest of these shellchecks - do you still want this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shellchecks were added, not removed, since shellcheck started complaining about the lack of an optional parameter.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oop, sorry, got it backwards.

@benmcclelland benmcclelland merged commit 34f60f1 into main Feb 13, 2025
24 checks passed
@benmcclelland benmcclelland deleted the test/rest_chunk_upload branch February 13, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants