fix: Adds PartNumber validation for CompleteMultipartUploads parts. A… #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dds a check to validate the parts order to be ascending.
benmcclelland
approved these changes
Feb 18, 2025
benmcclelland
merged commit ff0cf29
into
feat/object-integrity-checksums
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1072
Fixes #1063
Partsshould be sorted in ascending order forCompleteMultipartUpload. The PR adds a check to validate the parts order inCompleteMultipartUploadin bothposixandazurebackends.S3 has
partNumbervalidation onCompleteMultipartUpload: it should be greater than1. The PR adds this check.For the upper limits(10000) it simply returns
InvalidParterror as in the gateway.