Ben/s3proxy fixes #1091
Merged
Ben/s3proxy fixes #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The s3 sdk expects the version id and other input options to be nil when not specified. Otherwise it incorrectly accepts the "" string as the requested input option. This just sets the version id and otehr options back to nil if its "" from the s3api controller.
Updated the convertObjects function to initialize the result slice with a length of 0 and a capacity equal to the length of the input slice (objs). This fixes the problem where the results were being appended to a slice that already contained 0 value entries for the preallocated length.
benmcclelland
force-pushed
the
ben/s3proxy-fixes
branch
from
aff9fbc to
f7277e4
Compare
niksis02
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.