Support BucketLinks on admin command (Fix #1081) #1094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jbert
commented
Feb 27, 2025
jbert
commented
- Share code between backend/posix/ListBuckets and backend/posix/ListBucketsAndOwners, so both honour bucketlinks
- add some basic tests to backend/posix to check functionality working
- pulls in testify for string-array-equality (there were already references in go.mod, but easy to remove dependency if desired)
…spect --bucketlinks" versity#1081
- extract method to find top-level dirs, optionally including links to dirs - rework ListBuckets and ListBucketsAndOwners to use FileInfo rather than DirEntry Failing test now passes
|
This won't automatically run in continuous integration without approval. A member of the Versity organization must allow it. |
|
Thank you for the PR for this! Let me think about these added dependencies, we may be able to move this test into the systems tests instead. |
|
closing this PR, I cherry-picked and merged the fix without the tests in #1097. Will work with QA team to get this tested in system tests instead so that we dont have the extra dependencies and we can keep unit tests from needing a local fs. |
|
Awesome. Thanks for that, and apologies that I didn't understand the testing regime/separation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.