fix: Prioritize explicit deny in bucket policy statements #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niksis02
force-pushed
the
fix/bucket-policy-explicit-deny
branch
from
3f6c0e6 to
4967510
Compare
niksis02
force-pushed
the
fix/bucket-policy-explicit-deny
branch
from
4967510 to
30f3fac
Compare
benmcclelland
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1092
In multi-statement bucket policies, explicit
Denyrules should take precedence overAllowrules.This change updates the implementation to iterate through all policy statements. If a
Denystatement is found, it immediately returnsAccessDenied. If noDenystatement is found but anAllowstatement is present, access is granted.