fix: s3 backend requires nil values for input params #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For any uninitialized input values, the s3 sdk expects these to be set to nil instead of the type zero value. Setting to the zero value is incorrectly making the server request think we are trying to set those parameters. This sets all input parameters to nil for the default values. Many of these are already nil from the frontend, but this should protect against a future addition of input params for an api requests and not remembering to add teh zero value check on in the s3 backend. We were previously getting the following error for put-object: <Error><Code>InvalidArgument</Code><Message>x-amz-object-lock-retain-until-date and x-amz-object-lock-mode must both be supplied</Message><Resource></Resource><RequestId></RequestId><HostId></HostId></Error>
niksis02
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any uninitialized input values, the s3 sdk expects these to be set to nil instead of the type zero value. Setting to the zero value is incorrectly making the server request think we are trying to set those parameters.
This sets all input parameters to nil for the default values. Many of these are already nil from the frontend, but this should protect against a future addition of input params for an api requests and not remembering to add teh zero value check on in the s3 backend.
We were previously getting the following error for put-object:
InvalidArgumentx-amz-object-lock-retain-until-date and x-amz-object-lock-mode must both be supplied