fix: Implements a generic wildcard match for bucket policy resources #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niksis02
force-pushed
the
fix/bucket-policy-multi-wildcard-support
branch
from
6225647 to
8e50e90
Compare
niksis02
force-pushed
the
fix/bucket-policy-multi-wildcard-support
branch
from
8e50e90 to
9a02c47
Compare
benmcclelland
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1093
The gateway previously had a simple wildcard matching logic implemented, which only matched wildcards at the end of the pattern.
The changes introduce a new, more flexible wildcard matching logic for bucket policy resources:
?matches exactly one occurrence of any character.*matches any number of occurrences (including zero) of any character.Adds unit tests for all
Resourcetype methods.AWS docs