fix: cleanup backend ACLs #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlt180
previously approved these changes
Jan 10, 2024
backend/s3proxy/s3.go
Outdated
| tagout, err := s.client.GetBucketTagging(ctx, &s3.GetBucketTaggingInput{ | ||
| Bucket: &bucket, | ||
| }) | ||
| err = handleError(err) | ||
| if err != nil { |
There was a problem hiding this comment.
But these 2 actions are actually not supported in our gateway: GetBucketTagging, PutBucketTagging.
There was a problem hiding this comment.
I think this means that we cant use our gateway as a backend for s3proxy yet. we will need to think about if we want to support this stacking.
There was a problem hiding this comment.
I think we can add these 2 actions support in posix. That wouldn't be a big deal for us
| return SendResponse(ctx, fmt.Errorf("marshal acl: %w", err), &MetaOpts{Logger: c.logger, Action: "CreateBucket", BucketOwner: acct.Access}) | ||
| } | ||
|
|
||
| err = c.be.CreateBucket(ctx.Context(), &s3.CreateBucketInput{ |
There was a problem hiding this comment.
I think we have to support here to add bucket ACL on bucket creation, because the CLI and SDKs have this feature to define bucket ACL on creation. Maybe this could be a separate task?
There was a problem hiding this comment.
yeah, lets add a new issue for this
This adds the default ACL to the CreateBucket backend method so that the backend doesn't need to know how to construct and ACL. This also moves the s3proxy ACLs to a tag key/value because the gateway ACLs are not the same accounts as the backend s3 server. TODO: we may need to mask this tag key/value if we add support for the Get/PutBucketTagging API.
benmcclelland
force-pushed
the
ben/default_acl
branch
from
61d84af to
6481e2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the default ACL to the CreateBucket backend method so that the backend doesn't need to know how to construct and ACL.
This also moves the s3proxy ACLs to a tag key/value because the gateway ACLs are not the same accounts as the backend s3 server. TODO: we may need to mask this tag key/value if we add support for the Get/PutBucketTagging API.