Fix cargo build error when spec code includes !is
#1903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1573. My understanding here is that
rejoin_tokensused to not be necessary for compiling code because the spec code could be parsed even without it (but possibly with a different result than ifrejoin_tokenswas called?). With!is/!has, parsing fails and hence prevents compilation. Simply usingrejoin_tokensin this case as well seems to be the most straightforward solution.@tjhance Tagging you, since you reviewed #1882.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.