Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally, rustc de-sugars the 'x?' operation to something like this:
To support '?', we just need to add support for all the content in the de-sugar:
std::ops::ControlFlow
enum. This is easy withexternal_type_specification
.std::convert::Infallible
enum. This is an empty enum, which Verus doesn't support, but we can mark itexternal_body
.std::ops::Try
trait (specifically thebranch
function).FromResidual
traitResult should work the same way, but the problem is that the Result's implementation of FromResidual is more generic than we support right now. It's a similar problem to vec indexing, and we can work around it the same way, but this PR doesn't handle it.UPDATE: Result is now supported.