fix: githubApiToken not equal lead to bad credentials #70 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Apr 29, 2024
wey-gu
approved these changes
May 3, 2024
|
Wow, Thanks so much for the great work! And welcome to the NebulaGraph community! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#70
Description:
value of githubApiToken in
INITIAL_STATEandprocess.env.REACT_APP_GITHUB_API_TOKENnot same, which leads to miss-setting token when new `GithubFetcher(t).And local run get
401 bad credentialsHow do you solve it?
unify githubApiToken to
btoa(process.env.REACT_APP_GITHUB_API_TOKEN)Special notes for your reviewer, ex. impact of this fix, design document, etc: