Support multiple index statements in Field definitions#1097
Merged
Conversation
Co-authored-by: thomasht86 <24563696+thomasht86@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Support multiple
Support multiple index statements in Field definitions
Jul 29, 2025
index statements in Field-definition
Collaborator
|
@kkraune need another approval since I collaborated with Copilot on this one. 🙏 |
Member
|
nice work by the robot! |
kkraune
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements support for multiple
indexstatements in Vespa Field definitions, addressing a limitation where fields could only have a single index configuration.Problem
Previously, the schema template was hardcoded to render only one index statement per field:
index: {{ field.index }}This prevented defining fields with complex index configurations like:
Or fields requiring multiple index blocks with different configurations.
Solution
The implementation extends the
Fieldclass to accept multiple index configurations while maintaining full backward compatibility:API Changes
The
indexparameter now accepts:index="enable-bm25"index={"arity": 2, "lower-bound": 3}index=["enable-bm25", {"arity": 2}, "another-setting"]Examples
Single complex index block (from original issue):
Multiple index configurations:
Parameterless index settings:
Template Updates
Updated Jinja2 templates to iterate over multiple index configurations and handle parameterless settings (None values render without
: None).Backward Compatibility
All existing code continues to work unchanged. The new functionality is additive and doesn't break any existing Field definitions.
Testing
Added comprehensive test suite with 11 test cases covering:
Fixes #983.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.