thomasht86/include files java bundles tests#1278
Merged
Merged
Conversation
BrageHK
approved these changes
May 7, 2026
BrageHK
left a comment
BrageHK
left a comment
Contributor
There was a problem hiding this comment.
Looks good. The ipynb files seems automatically formatted, which is unnecessary, but it does not make any difference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
In #1270 we added support for adding files to app package.
One of the more common use cases for this is adding Java bundles, ref #1184.
Adding a test and example for doing this with the new feature from #1270.
I used Claude for this, but tested and validated thoroughly.
Only adding test and docs, so high confidence.