Geo distance grouping supports multivalue argument in indexed search#36222
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends GeoDistanceFunctionNode so geo distance grouping can work with multivalue (array) position attributes in indexed search by computing the minimum distance across all positions.
Changes:
- Document multivalue (
array<position>) behavior for geo distance (min distance returned). - Update
GeoDistanceFunctionNode::onExecute()to support both single-value andResultNodeVectorinputs. - Add/adjust aggregator expression tests to cover multivalue geo distance behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
searchlib/src/vespa/searchlib/expression/geo_distance_function_node.h |
Documents the new multivalue semantics (min distance). |
searchlib/src/vespa/searchlib/expression/geo_distance_function_node.cpp |
Implements min-distance reduction when the attribute argument is a ResultNodeVector. |
searchlib/src/tests/aggregator/perdocexpr_test.cpp |
Refactors geo test fixtures and adds a new multivalue geo distance unit test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Continuation of #36174 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for geo_distance in grouping on a field that is array of positions.
@arnej27959 please review