Add FlushStrategyResult. Add strategy_info to flush history.#36943
Merged
Conversation
vekterli
previously approved these changes
May 20, 2026
| } | ||
|
|
||
| const std::string strategy_name("memory"); | ||
| const std::string no_info("none"); |
Member
There was a problem hiding this comment.
Philosophical question: is it best to communicate no info with an explicit "none" string or an empty string? 🤔
| if (LOG_WOULD_LOG(event)) { | ||
| EventLogger::flushInit(it->getName()); | ||
| auto& strategy_info = flush_strategy_result.strategy_info(); | ||
| auto& strategy_name = flush_strategy_result.strategy_name(); |
Member
There was a problem hiding this comment.
Consider making auto-refs const auto& to make it more immediately obvious that they are non-mutable refs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@vekterli : please review
@arnej27959 : FYI