Skip to content

Re-organize QueryEvalStats class and collection of these stats#36948

Merged
boeker merged 7 commits into
masterfrom
boeker/reorganize-query-eval-stats-collection
May 20, 2026
Merged

Re-organize QueryEvalStats class and collection of these stats#36948
boeker merged 7 commits into
masterfrom
boeker/reorganize-query-eval-stats-collection

Conversation

@boeker
Copy link
Copy Markdown
Contributor

@boeker boeker commented May 20, 2026

Splits the class QueryEvalStats into QuerySetupStats (not thread safe, written to in NearestNeighborBlueprint) and QueryEvalStats (thread safe, written to in ExactNearestNeighborIterator). The ANN stats in QueryEvalStats were atomic before, but I do not see a reason for this as we only write to these in the query setup and not from the search iterators.

The class QuerySetupStats is then wired into the perform_ann_searches method to avoid the awkward flushing in the NearestNeighborBlueprint (the QueryEvalStats was and is not installed when performing the ANN searches).

@boeker boeker requested a review from havardpe May 20, 2026 09:37
@boeker
Copy link
Copy Markdown
Contributor Author

boeker commented May 20, 2026

Maybe I should call the QuerySetupStats class AnnStats or something like that instead since it is so specific. 🤔

@boeker boeker merged commit 37d2650 into master May 20, 2026
3 checks passed
@boeker boeker deleted the boeker/reorganize-query-eval-stats-collection branch May 20, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants