Revise server port docs #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now `npm run serve` should listen on port 3001 as documented in the README. Also document how to change the port for `npm run serve`. This should fix #476.
Actually, we need `npm run serve` to be on port 3000 by default because we run the demo server with it, and I don't want to set up a real production configuration for it. But now the docs say what to do if port 3000 is in use, and show you actually going to port 3000 to use the tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #476 by changing the docs to point at the port we actually run the server from
npm run serveon, and documenting how to move it on the command line and why you might need to.I wanted to move the
npm run serveuser-facing port you actually need to browse to to be 3001, the same as thenpm run startone, but I couldn't work out how to do that while respectingconfig.json'sserverPortand not needing new config for the demo deployment.